Download library index as a combined archive+signature #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
Codecov ReportBase: 36.67% // Head: 36.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1908 +/- ##
==========================================
- Coverage 36.67% 36.62% -0.05%
==========================================
Files 231 231
Lines 19684 19683 -1
==========================================
- Hits 7219 7209 -10
- Misses 11635 11646 +11
+ Partials 830 828 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
umbynos
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Download
library_index.jsonas a combined index+signature archive from the new URL: https://downloads.arduino.cc/libraries/library_index.tar.bz2What is the current behavior?
Library index was downloaded separately from signature: this lead to sporadic incorrect signature verification.
What is the new behavior?
The index and signature are obtained from a single tar.bz2 archive (that also provide a bit of saving of the file size).
Does this PR introduce a breaking change, and is titled accordingly?
No